pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.34k stars 5.85k forks source link

lightning: remove some `NOT NULL` constraints on lightning table (#57577) #57600

Closed ti-chi-bot closed 9 hours ago

ti-chi-bot commented 1 day ago

This is an automated cherry-pick of #57577

What problem does this PR solve?

Issue Number: close #57578

Problem Summary:

What changed and how does it work?

https://github.com/pingcap/tidb/pull/55477 change the behavior of null value insert. To adapt to this change, some NOT NULL constraints have to be removed.

Previous PR just wrongly change INSERT INTO to INSERT IGNORE INTO, which may case data correctness.

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-8.5@6404c67). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-8.5 #57600 +/- ## ================================================ Coverage ? 57.1101% ================================================ Files ? 1770 Lines ? 628221 Branches ? 0 ================================================ Hits ? 358778 Misses ? 245502 Partials ? 23941 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `37.0904% <ø> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.7956% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57600/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57600/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.9478% <0.0000%> (?)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57600/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <0.0000%> (?)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57600/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.3192% <0.0000%> (?)` | |

🚨 Try these New Features:

ti-chi-bot[bot] commented 10 hours ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 10 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, fzzf678, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/lightning/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/pkg/lightning/OWNERS)~~ [Benjamin2037,lance6716] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment