Open ti-chi-bot opened 1 day ago
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kennytm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-11-22 02:09:51.470354412 +0000 UTC m=+170379.090008926
: :ballot_box_with_check: agreed by kennytm.
This is an automated cherry-pick of #57593
What problem does this PR solve?
Issue Number: close #57585
Problem Summary: Some values from the command line are not properly redacted.
What changed and how does it work?
In additional to the existing handling for
--storage
, we also apply redaction to the following parameters:--full-backup-storage
--crypter.key
--log.crypter.key
--azblob.encryption-key
--master-key
(the current implementation of this may be too conservative)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.