Open Tristan1900 opened 20 hours ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign leavrth for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @Tristan1900. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
/ok-to-test
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.3187%. Comparing base (
49c3eba
) to head (b44989e
). Report is 177 commits behind head on master.
🚨 Try these New Features:
/retest
@Tristan1900: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
fast_test_tiprow | b44989e8d1eaf69c330cc20caa6ad3b850d8fced | link | true | /test fast_test_tiprow |
tidb_parser_test | b44989e8d1eaf69c330cc20caa6ad3b850d8fced | link | true | /test tidb_parser_test |
Full PR test history. Your PR dashboard.
What problem does this PR solve?
Issue Number: close #57609
Problem Summary:
What changed and how does it work?
Extract the wait for checkpoint to advance logic in integration test to a method
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.