pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.34k stars 5.85k forks source link

br: refactor test to use wait checkpoint method #57612

Open Tristan1900 opened 20 hours ago

Tristan1900 commented 20 hours ago

What problem does this PR solve?

Issue Number: close #57609

Problem Summary:

What changed and how does it work?

Extract the wait for checkpoint to advance logic in integration test to a method

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
ti-chi-bot[bot] commented 20 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign leavrth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[br/OWNERS](https://github.com/pingcap/tidb/blob/master/br/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tiprow[bot] commented 20 hours ago

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Tristan1900 commented 20 hours ago

/ok-to-test

codecov[bot] commented 19 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.3187%. Comparing base (49c3eba) to head (b44989e). Report is 177 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57612 +/- ## ================================================ + Coverage 73.2689% 74.3187% +1.0498% ================================================ Files 1650 1691 +41 Lines 455646 489758 +34112 ================================================ + Hits 333847 363982 +30135 - Misses 101279 103622 +2343 - Partials 20520 22154 +1634 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57612/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `46.5437% <ø> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.1942% <ø> (-0.3651%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57612/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57612/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.7673% <ø> (-0.1806%)` | :arrow_down: | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57612/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57612/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `58.0080% <ø> (+12.0074%)` | :arrow_up: |

🚨 Try these New Features:

Tristan1900 commented 16 hours ago

/retest

tiprow[bot] commented 11 hours ago

@Tristan1900: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow b44989e8d1eaf69c330cc20caa6ad3b850d8fced link true /test fast_test_tiprow
tidb_parser_test b44989e8d1eaf69c330cc20caa6ad3b850d8fced link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).