Open Lloyd-Pottiger opened 2 years ago
@Lloyd-Pottiger, could you assign this ticket to me? I have interest to do the first issue.
@Lloyd-Pottiger, could you assign this ticket to me? I have interest to do the first issue.
Sure, may be you can talk about your ideas about the solutions?
@Lloyd-Pottiger, the solution is that removes embedded member functions for gtest in dbms/src/Storages/Page
and adds embedded member functions to a common basic TestSuite
. Right?
@Lloyd-Pottiger, the solution is that removes embedded member functions for gtest in
dbms/src/Storages/Page
and adds embedded member functions to a common basicTestSuite
. Right?
@SteNicholas Those functions are only needed for gtest, so we can just remove them. However, in gtests, we used them, and we should keep the normal usage of gtests and can not delete gtests. May we can change the function we called in gtests line by line which is a huge project, or add marco like #define read(x) read(TEST_NAMESPACE_ID, x)
which could not work for every case, and so on. Looking forward to fancy ideas!
Enhancement
There are some embedded member function in the directory
dbms/src/Storages/Page
likePS::V3::PageStorageImpl
which is just for tests. This is not a elegant code style, and we need to remove them.