Remove embedded member function for gtest in `dbms/src/Storages/Page`

[Lloyd-Pottiger]

Enhancement

There are some embedded member function in the directory dbms/src/Storages/Page like PS::V3::PageStorageImpl

#ifndef NDEBUG
    // Just for tests, refactor them out later
    DB::PageStorage::SnapshotPtr getSnapshot() { return getSnapshot(""); }
    DB::PageEntry getEntry(PageId page_id) { return getEntryImpl(TEST_NAMESPACE_ID, page_id, nullptr); }
    DB::Page read(PageId page_id) { return readImpl(TEST_NAMESPACE_ID, page_id, nullptr, nullptr); }
    PageMap read(const std::vector<PageId> & page_ids) { return readImpl(TEST_NAMESPACE_ID, page_ids, nullptr, nullptr); }
    void read(const std::vector<PageId> & page_ids, const PageHandler & handler) { return readImpl(TEST_NAMESPACE_ID, page_ids, handler, nullptr, nullptr); }
    PageMap read(const std::vector<PageReadFields> & page_fields) { return readImpl(TEST_NAMESPACE_ID, page_fields, nullptr, nullptr); }
#endif

which is just for tests. This is not a elegant code style, and we need to remove them.

[SteNicholas]

@Lloyd-Pottiger, could you assign this ticket to me? I have interest to do the first issue.

[Lloyd-Pottiger]

@Lloyd-Pottiger, could you assign this ticket to me? I have interest to do the first issue.

Sure, may be you can talk about your ideas about the solutions?

[SteNicholas]

@Lloyd-Pottiger, the solution is that removes embedded member functions for gtest in dbms/src/Storages/Page and adds embedded member functions to a common basic TestSuite. Right?

[Lloyd-Pottiger]

@Lloyd-Pottiger, the solution is that removes embedded member functions for gtest in dbms/src/Storages/Page and adds embedded member functions to a common basic TestSuite. Right?

@SteNicholas Those functions are only needed for gtest, so we can just remove them. However, in gtests, we used them, and we should keep the normal usage of gtests and can not delete gtests. May we can change the function we called in gtests line by line which is a huge project, or add marco like #define read(x) read(TEST_NAMESPACE_ID, x) which could not work for every case, and so on. Looking forward to fancy ideas!