search

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
941 stars 409 forks source link

Improve the performance of string search #6836

Open Lloyd-Pottiger opened 1 year ago

Lloyd-Pottiger commented 1 year ago

Enhancement

Possible solution:

ryuusama09 commented 10 months ago

Hello , I would like to tackle this issue. I am a new contributor here , so please let me know if there are any rules !

Lloyd-Pottiger commented 10 months ago

@ryuusama09 cool, thanks! I will assign this issue to you. There are no extra rules. It would be better if you could share your design first.

ryuusama09 commented 10 months ago

@Lloyd-Pottiger I havent thought much about the design . However We can use a powerful data structure like suffix automata to perform the string search. This is just a proposal. Once we finalize what to choose , then we can proceed with the design. sounds good ?

Lloyd-Pottiger commented 10 months ago

@ryuusama09 Sounds worth a try! Looking forward to your pr and benchmark result!

ryuusama09 commented 10 months ago

@Lloyd-Pottiger , is there any command for windows to download all dependencies for the system ?

Lloyd-Pottiger commented 10 months ago

@Lloyd-Pottiger , is there any command for windows to download all dependencies for the system ?

@ryuusama09 It is suggested to use WSL. We have not tested in Windows, there may be a lot of unknow problems.