search

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
945 stars 409 forks source link

find a proper way to handle fail during proxy initializing #8461

Open Lloyd-Pottiger opened 10 months ago

Lloyd-Pottiger commented 10 months ago

Enhancement

https://github.com/pingcap/tiflash/blob/68181844e5a9e0643583bd51ddcf03e909d71cdb/dbms/src/Server/Server.cpp#L1040-L1043

Now TiFlash server will keep on waiting for proxy init by checking whether proxy_helper is nullptr. But the proxy may fail before setting proxy. TiFlash can not be aware that proxy has failed, just keep on waiting...

CalvinNeo commented 10 months ago

Another maybe related feature request https://github.com/pingcap/tiflash/issues/8478