Storages: Splitting DMFileReaderPool to reduce lock contention (#9126)

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

937 stars 409 forks source link

Storages: Splitting DMFileReaderPool to reduce lock contention (#9126) #9129

Closed ti-chi-bot closed 1 month ago

ti-chi-bot commented 1 month ago

This is an automated cherry-pick of #9126

What problem does this PR solve?

Issue Number: close #9125

Problem Summary:

What is changed and how it works?

Check List

Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
- Run simple queries (select max(k) from sbtest1) concurrently.
- Time consumption unit: ms.

Concurrency	Master	This PR
1	27	25
2	28	29
4	46	46
8	72	77
16	124	97
32	232	160
64	450	327

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Improve the short queries performance under high concurrency by reducing the lock contention

JinheLin commented 1 month ago

/test

ti-chi-bot[bot] commented 1 month ago

@JinheLin: No presubmit jobs available for pingcap/tiflash@release-8.1

In response to [this](https://github.com/pingcap/tiflash/pull/9129#issuecomment-2154103838): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

JinheLin commented 1 month ago

/run-all-tests

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/release-8.1/OWNERS)~~ [JaySon-Huang,JinheLin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

2024-06-07 06:00:20.125255474 +0000 UTC m=+98774.178567397: :ballot_box_with_check: agreed by JaySon-Huang.
2024-06-07 06:30:47.792236138 +0000 UTC m=+100601.845548062: :ballot_box_with_check: agreed by JinheLin.