Storages: Track memory for PageDirectory

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

936 stars 409 forks source link

Storages: Track memory for PageDirectory #9134

Closed CalvinNeo closed 3 weeks ago

CalvinNeo commented 4 weeks ago

What problem does this PR solve?

Issue Number: close #8835

Problem Summary:

What is changed and how it works?

Add metrics for the memory allocated for UniversalPageId and EntryOrDelete

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

CalvinNeo commented 3 weeks ago

===> After review, change to following

CalvinNeo commented 3 weeks ago

/hold

CalvinNeo commented 3 weeks ago

/retest

ti-chi-bot[bot] commented 3 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-06-11 09:39:41.713743811 +0000 UTC m=+457535.767055734: :ballot_box_with_check: agreed by Lloyd-Pottiger.
2024-06-13 09:22:55.693801303 +0000 UTC m=+629329.747113229: :ballot_box_with_check: agreed by JaySon-Huang.

ti-chi-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,JinheLin,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

CalvinNeo commented 3 weeks ago

/unhold

CalvinNeo commented 3 weeks ago

Also update the grafana panel JSON?

Rest LGTM

updated

CalvinNeo commented 3 weeks ago

/test

ti-chi-bot[bot] commented 3 weeks ago

@CalvinNeo: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test pull-integration-test
/test pull-unit-test

Use /test all to run all jobs.

In response to [this](https://github.com/pingcap/tiflash/pull/9134#issuecomment-2165348799): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.