Closed JaySon-Huang closed 3 weeks ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-06-11 08:04:20.699109698 +0000 UTC m=+451814.752421617
: :ballot_box_with_check: agreed by Lloyd-Pottiger.2024-06-12 07:13:50.509961269 +0000 UTC m=+535184.563273193
: :ballot_box_with_check: agreed by CalvinNeo.@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
trigger some heavy tests which will not run always when PR updated.
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tiflash/issues/6233
Problem Summary:
What is changed and how it works?
Simplify nesting if..else code in
TiFlashSecurity.h
Check List
Tests
Side effects
Documentation
Release note