Storages: Change the element type of `use_pack` from `bool` to `RSResult` in `DMFilePackFilter`

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

936 stars 409 forks source link

Storages: Change the element type of `use_pack` from `bool` to `RSResult` in `DMFilePackFilter` #9145

Closed JinheLin closed 3 weeks ago

JinheLin commented 3 weeks ago

What problem does this PR solve?

Issue Number: ref #9103

What is changed and how it works?

1. Change `std::vector<UInt8> use_packs;` to `std::vector<RSResult> pack_res;`. 
2. Add statistical data of filtering results in `ScanContext`.

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

JinheLin commented 3 weeks ago

/retest

ti-chi-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 3 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-06-13 09:20:48.9811205 +0000 UTC m=+629203.034432417: :ballot_box_with_check: agreed by Lloyd-Pottiger.
2024-06-13 10:35:24.631911759 +0000 UTC m=+633678.685223683: :ballot_box_with_check: agreed by JaySon-Huang.

ti-chi-bot[bot] commented 3 weeks ago

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.