Closed JaySon-Huang closed 3 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JinheLin, Lloyd-Pottiger
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-06-14 15:17:00.400014162 +0000 UTC m=+736974.453326086
: :ballot_box_with_check: agreed by JinheLin.2024-06-16 02:20:18.966410458 +0000 UTC m=+863173.019722382
: :ballot_box_with_check: agreed by Lloyd-Pottiger.@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
trigger some heavy tests which will not run always when PR updated.
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
New changes are detected. LGTM label has been removed.
What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tiflash/issues/6233
Problem Summary:
DB::buildPushDownFilter
is being called inPushDownFilter::build
, moving that function to beDAGExpressionAnalyzer::buildPushDownFilter
is more reasonablecontent
in Unsupported RSOperator is verbose and useless, replace it by a string with sufficient messageWhat is changed and how it works?
pb.ShortDebugString
when the rough set filter is not supportedDB::buildPushDownFilter
->DAGExpressionAnalyzer::buildPushDownFilter
stringstream
byFmtBuffer
inExpressionActions
Check List
Tests
Side effects
Documentation
Release note