Storages: MinMaxIndex::checkIsNull returns RSResult::All if a pack only contains null marks and delete marks

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

936 stars 409 forks source link

Storages: MinMaxIndex::checkIsNull returns RSResult::All if a pack only contains null marks and delete marks #9152

Closed JinheLin closed 2 weeks ago

JinheLin commented 2 weeks ago

What problem does this PR solve?

Issue Number: ref #9103

What is changed and how it works?

Before this PR, checkIsNull will never return RSResult::All.
This PR makes checkIsNull return RSResult::All if a pack conatins null marks and no value (maybe some delete marks exists).

Check List

Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

JaySon-Huang commented 2 weeks ago

simplify the test case by utils in TestUtils/FunctionTestUtils.h https://github.com/JinheLin/tiflash-1/pull/2/files

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-06-19 03:08:02.83364663 +0000 UTC m=+170609.319135460: :ballot_box_with_check: agreed by JaySon-Huang.
2024-06-19 03:11:08.39303603 +0000 UTC m=+170794.878524855: :ballot_box_with_check: agreed by Lloyd-Pottiger.