pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
936 stars 409 forks source link

Storages: Fix memory trace for UniversalPageId #9163

Closed CalvinNeo closed 1 week ago

CalvinNeo commented 1 week ago

What problem does this PR solve?

Issue Number: close #8835

Problem Summary: We don't trace when a UniversalPageId is move-constructed or move-assigned, so we may count a memory release twice

image

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

None
CalvinNeo commented 1 week ago

/cc @JaySon-Huang @JinheLin @Lloyd-Pottiger

ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,JinheLin,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Lloyd-Pottiger commented 1 week ago

/hold

TODO: fix tidy

JaySon-Huang commented 1 week ago

/test pull-integration-test

CalvinNeo commented 1 week ago

/unhold