*: update minimum cmake version to 3.23

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

943 stars 410 forks source link

*: update minimum cmake version to 3.23 #9164

Closed Lloyd-Pottiger closed 3 months ago

Lloyd-Pottiger commented 3 months ago

What problem does this PR solve?

Issue Number: close #8898, close #7193

Problem Summary:

cmake need to be upgrade to 3.23 at least for building under mac os with clang 14.0.0

What is changed and how it works?

update minimum cmake version to 3.23

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,JinheLin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

2024-06-27 02:01:38.400329125 +0000 UTC m=+857824.885817970: :ballot_box_with_check: agreed by JaySon-Huang.
2024-06-27 02:25:49.473554152 +0000 UTC m=+859275.959042985: :ballot_box_with_check: agreed by JinheLin.

wuhuizuo commented 3 months ago

/cherry-pick release-8.2

ti-chi-bot commented 3 months ago

@wuhuizuo: new pull request created to branch release-8.2: #9168.

In response to [this](https://github.com/pingcap/tiflash/pull/9164#issuecomment-2196044647): >/cherry-pick release-8.2 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.