pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
936 stars 409 forks source link

Storages: Fix returned column types may not match in late-materialization #9176

Closed JinheLin closed 2 days ago

JinheLin commented 3 days ago

What problem does this PR solve?

Issue Number: close #9175

Problem Summary: #9175

+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| id                     | estRows | task         | access object | operator info                                                      |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| TableReader_13         | 128.00  | root         |               | MppVersion: 2, data:ExchangeSender_12                              |
| └─ExchangeSender_12    | 128.00  | mpp[tiflash] |               | ExchangeType: PassThrough                                          |
|   └─Projection_5       | 128.00  | mpp[tiflash] |               | hour(test.t.a)->Column#4, test.t.i                                 |
|     └─TableFullScan_10 | 128.00  | mpp[tiflash] | table:t       | pushed down filter:eq(test.t.a, 24:11:11.123500), keep order:false |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

Fix the issue of column types that may not match in late-materialization.
ti-chi-bot[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 days ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-8.1: #9180.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-7.5: #9181.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-7.1: #9182.