Closed JinheLin closed 1 month ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-08-26 05:43:27.647344853 +0000 UTC m=+762602.781794974
: :ballot_box_with_check: agreed by Lloyd-Pottiger.2024-08-26 05:51:43.06623896 +0000 UTC m=+763098.200689083
: :ballot_box_with_check: agreed by CalvinNeo./cherry-pick release-7.5
@Lloyd-Pottiger: new pull request created to branch release-7.5
: #9480.
/cherry-pick release-8.1
/cherry-pick release-7.1
@Lloyd-Pottiger: new pull request created to branch release-8.1
: #9481.
@Lloyd-Pottiger: new pull request created to branch release-7.1
: #9482.
What problem does this PR solve?
Issue Number: close #9348, ref https://github.com/pingcap/tiflash/issues/9103
Problem Summary:
If Min-Max index returns RSResult::All, we will create a EMPTY filter column to make some checks on block structure happy. https://github.com/pingcap/tiflash/blob/f0a4087d599a19645820b0bc9c48d9b80906541f/dbms/src/DataStreams/FilterTransformAction.cpp#L77-L85
In LateMaterializationBlockInputStream, filter_column_stream does not execute projecting to remove filter column, and will execute filtering in https://github.com/pingcap/tiflash/blob/f0a4087d599a19645820b0bc9c48d9b80906541f/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp#L72-L75
This result issue #9348.
What is changed and how it works?
Skip filtering for filter column as https://github.com/pingcap/tiflash/blob/f0a4087d599a19645820b0bc9c48d9b80906541f/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp#L113-L117
Add add unit-test for this case.
Check List
Tests
Side effects
Documentation
Release note