pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
944 stars 410 forks source link

avoid potential TiFlash crash in `NonJoinedBlockInputStream` #9364

Closed windtalker closed 1 month ago

windtalker commented 1 month ago

What problem does this PR solve?

Issue Number: close #9190

Problem Summary: Hold shared pointer of Join in NonJoinedBlockInputStream

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

None
ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/release-6.5/OWNERS)~~ [gengliqi,yibin87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

windtalker commented 1 month ago

/run-all-tests

windtalker commented 1 month ago

/run-unit-tests

ti-chi-bot commented 1 month ago

In response to a cherrypick label: new pull request created to branch release-6.1: #9368.

ti-chi-bot commented 1 month ago

In response to a cherrypick label: new pull request created to branch release-5.4: #9369.