Closed Lloyd-Pottiger closed 1 month ago
LocalIndexerScheduler::Task::dmfile_ids is changed to LocalIndexerScheduler::Task::page_ids
Maybe need some better design (or names), since after logical split the left and right segment will hold the same dmfile_id but different page_id.
LocalIndexerScheduler::Task::dmfile_ids is changed to LocalIndexerScheduler::Task::page_ids
Maybe need some better design (or names), since after logical split the left and right segment will hold the same dmfile_id but different page_id.
@breezewish rename to
// The file id of the DMFile.
struct DMFileID
{
explicit DMFileID(PageIdU64 id_)
: id(id_)
{}
PageIdU64 id;
};
// The page id of the ColumnFileTiny.
struct ColumnFileTinyID
{
explicit ColumnFileTinyID(PageIdU64 id_)
: id(id_)
{}
PageIdU64 id;
};
using FileID = std::variant<DMFileID, ColumnFileTinyID>;
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CalvinNeo, JaySon-Huang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-09-04 08:51:37.697110388 +0000 UTC m=+434422.215163310
: :ballot_box_with_check: agreed by JaySon-Huang.2024-09-04 11:27:39.341103479 +0000 UTC m=+443783.859156401
: :ballot_box_with_check: agreed by CalvinNeo./test pull-integration-test
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Extract
LocalIndexerScheduler
from https://github.com/tidbcloud/tiflash-cse/pull/203 to reduce the difficulty of code review. Meanwhile,LocalIndexerScheduler::Task::dmfile_ids
is changed toLocalIndexerScheduler::Task::file_ids
, which means we use page ids to identify each task, so we can add task for ColumnFileTiny later.Check List
Tests
Side effects
Documentation
Release note