fix lpad/rpad trailing zero miss (#9610)

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

948 stars 410 forks source link

fix lpad/rpad trailing zero miss (#9610) #9634

Closed ti-chi-bot closed 5 days ago

ti-chi-bot commented 1 week ago

This is an automated cherry-pick of #9610

What problem does this PR solve?

Issue Number: close #9465

Problem Summary:

What is changed and how it works?

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

fix lpad/rpad trailing zero miss

ti-chi-bot[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/release-6.1/OWNERS)~~ [guo-shaoge,windtalker] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 5 days ago

[LGTM Timeline notifier]

Timeline:

2024-11-19 05:10:53.8165365 +0000 UTC m=+937816.007405492: :ballot_box_with_check: agreed by windtalker.
2024-11-20 06:17:34.626969897 +0000 UTC m=+12442.246624413: :ballot_box_with_check: agreed by guo-shaoge.

JaySon-Huang commented 5 days ago

/run-all-tests