fix error when first argument of replace function is const (#9615)

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

948 stars 410 forks source link

fix error when first argument of replace function is const (#9615) #9641

Closed ti-chi-bot closed 5 days ago

ti-chi-bot commented 1 week ago

This is an automated cherry-pick of #9615

What problem does this PR solve?

Issue Number: close #9522

Problem Summary:

What is changed and how it works?

1. remove some useless arguments(pos, occ, match_type)
2. support first argument as ColumnConst

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

fix error when first argument of replace function is const

ti-chi-bot[bot] commented 1 week ago

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

It must be approved by the approvers firstly.
AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from guo-shaoge, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiflash/blob/release-6.1/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

guo-shaoge commented 5 days ago

trivial bug, will not cherry pick