pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
948 stars 410 forks source link

*: Fix build and readme in llvm17 #9656

Closed breezewish closed 5 days ago

breezewish commented 5 days ago

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflash/issues/6233

Problem Summary:

What is changed and how it works?

Fix README instruction for MacOS
Fix build unit test failure in LLVM17 + MacOS

This doesn't work, so removed: "use CMAKE_C_COMPILER and CMAKE_CXX_COMPILER to specify the compiler"

Check List

Tests

Side effects

Documentation

Release note

None
ti-chi-bot[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,Lloyd-Pottiger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 5 days ago

[LGTM Timeline notifier]

Timeline:

JinheLin commented 5 days ago

/retest

ti-chi-bot[bot] commented 5 days ago

@breezewish: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
JaySon-Huang commented 5 days ago

happen to unstable test: https://github.com/pingcap/tiflash/issues/9662

JaySon-Huang commented 5 days ago

/test pull-unit-test