redo(ticdc): fix orderliness of redo

pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)

Apache License 2.0

417 stars 272 forks source link

redo(ticdc): fix orderliness of redo #11320

Closed hongyunyan closed 2 weeks ago

hongyunyan commented 2 weeks ago

What problem does this PR solve?

Issue Number: close #11096,#11321

What is changed and how it works?

Considering the row info in 6.5 is not the same as 8.1, to support the comparation, we need to support related isUpdate/isDelete/isInsert

Check List

Tests

Unit test
Manual test (add detailed scripts or steps below) create mysql sink changefeed with redo log on run gotpc workload After 30m, pause changefeed and run redo apply

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

hongyunyan commented 2 weeks ago

/retest

hongyunyan commented 2 weeks ago

retest

hongyunyan commented 2 weeks ago

/retest

hongyunyan commented 2 weeks ago

/retest

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/release-6.5/OWNERS)~~ [CharlesCheung96,asddongmen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-06-17 06:54:46.670194674 +0000 UTC m=+11413.155683501: :ballot_box_with_check: agreed by asddongmen.
2024-06-17 08:39:44.123818097 +0000 UTC m=+17710.609306930: :ballot_box_with_check: agreed by CharlesCheung96.