pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
417 stars 272 forks source link

Revert "cdc: log slow conflict detect every 60s (#11251) (#11287)" #11324

Closed hicqu closed 2 weeks ago

hicqu commented 2 weeks ago

This reverts commit 053cdaf4a6853e8c9fd4bff1deeb686d1fdb2654.

What problem does this PR solve?

Issue Number: close #11323

What is changed and how it works?

Revert #11287.

When applying events from Redo logs, events are not attached with TableID. Now we can revert this PR to avoid the problem.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None
ti-chi-bot[bot] commented 2 weeks ago

@hongyunyan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiflow/pull/11324#pullrequestreview-2124961475): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/release-6.5/OWNERS)~~ [3AceShowHand,asddongmen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: