Closed SandeepPadhi closed 1 week ago
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zhaoxinyu for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: SandeepPadhi
:x: Sandeep Padhi
Welcome @SandeepPadhi!
It looks like this is your first PR to pingcap/tiflow 🎉.
I'm the bot to help you request reviewers, add labels and more, See available commands.
We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to pingcap/tiflow. :smiley:
Hi @SandeepPadhi. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue
label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123
or Issue Number: ref #456
.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
What problem does this PR solve?
Added support for HTTP and HTTPS schema for pulsar downstream. Currently, only pulsar and pulsar+ssl support is there. Issue: Issue Number: 11336 Ref: https://github.com/pingcap/tiflow/issues/11336
What is changed and how it works?
-> In addition to pulsar and pulsar+ssl schema types in pulsar changefeed creation , users will now will able to create changefeeds with HTTP and HTTPS type as broker schema for pulsar client.
Clients have to use:
Tests
Questions
Will it cause performance regression or break compatibility?
-> It should not cause any performance regression or break compatibility. It only addition schema addition for pulsar client creation.
Do you need to update user documentation, design documentation or monitoring documentation?
-> Currently, documentation for pulsar downstream is not available on official document.