pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
417 stars 272 forks source link

metrics(ticdc): add kafka compression ratio description for grafana #11348

Closed sdojjy closed 1 week ago

sdojjy commented 1 week ago

What problem does this PR solve?

Issue Number: close #11347

What is changed and how it works?

add kafka compression ratio description for grafana

image

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/master/OWNERS)~~ [3AceShowHand,asddongmen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline:

sdojjy commented 1 week ago

/retest-required

sdojjy commented 1 week ago

/retest-required

sdojjy commented 1 week ago

/retest-required

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6426%. Comparing base (a2e6219) to head (d2918fd).

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.4595% <ø> (+0.0304%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `51.1990% <ø> (-0.0283%)` | :arrow_down: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `63.4091% <ø> (+0.0352%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `57.6426% <ø> (+0.0079%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11348 +/- ## ================================================ + Coverage 57.6347% 57.6426% +0.0079% ================================================ Files 849 849 Lines 126160 126160 ================================================ + Hits 72712 72722 +10 + Misses 48048 48038 -10 Partials 5400 5400 ```
ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-8.1: #11352.

ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-7.5: #11353.