server(ticdc): remove unused cdc-v2 configuration

sdojjy commented 6 days ago

What problem does this PR solve?

Issue Number: close #11354

What is changed and how it works?

The below cdc-v2 configuration is not used anymore, and ticdc will implement the new architecture in another way, so remove it to reduce the codebase.

furthermore, it's a debug configuration, so we can remove it without breaking the compatibility

[debug.cdc-v2]
enable=false

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

sdojjy commented 6 days ago

/retest-required

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6802%. Comparing base (401b2bc) to head (cee0a1d). Report is 2 commits behind head on master.

Additional details and impacted files

| [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.5184% <ø> (+0.0974%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `51.2252% <ø> (+0.0140%)` | :arrow_up: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `63.4020% <ø> (ø)` | | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11355/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `57.6802% <ø> (+0.0525%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11355 +/- ## ================================================ + Coverage 57.6276% 57.6802% +0.0525% ================================================ Files 849 848 -1 Lines 126160 126123 -37 ================================================ + Hits 72703 72748 +45 + Misses 48055 47985 -70 + Partials 5402 5390 -12 ```

ti-chi-bot[bot] commented 5 days ago

@kevin-xianliu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiflow/pull/11355#pullrequestreview-2146633069): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, kevin-xianliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/master/OWNERS)~~ [3AceShowHand,asddongmen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 5 days ago

[LGTM Timeline notifier]

Timeline:

2024-06-27 02:50:15.636285726 +0000 UTC m=+860742.121774558: :ballot_box_with_check: agreed by 3AceShowHand.
2024-06-28 01:59:29.4900454 +0000 UTC m=+944095.975534238: :ballot_box_with_check: agreed by asddongmen.

sdojjy commented 5 days ago

/retest-required

sdojjy commented 2 days ago

/retest-required

sdojjy commented 1 day ago

/retest-required

ti-chi-bot[bot] commented 1 day ago

@sdojjy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cdc-integration-kafka-test	cee0a1d272a7f523c44b717ba1cea004ad9b5fb9	link	true	`/test cdc-integration-kafka-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

pingcap / tiflow