pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
417 stars 272 forks source link

filter(ticdc): Add `lightning_task_info` as the system table schema that should not be replicated by TiCDC #11359

Closed hongyunyan closed 6 days ago

hongyunyan commented 6 days ago

What problem does this PR solve?

Issue Number: close #11356

What is changed and how it works?

Add lightning_task_info as the system table schema that should not be replicated by TiCDC

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.
ti-chi-bot[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/master/OWNERS)~~ [3AceShowHand,asddongmen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 6 days ago

[LGTM Timeline notifier]

Timeline:

hongyunyan commented 6 days ago

/test verify

hongyunyan commented 6 days ago

/test dm-integration-test

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6393%. Comparing base (401b2bc) to head (0a0c2ea). Report is 1 commits behind head on master.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.4399% <100.0000%> (+0.0188%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `51.2111% <ø> (ø)` | | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `63.4232% <ø> (+0.0211%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `57.6393% <100.0000%> (+0.0117%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11359 +/- ## ================================================ + Coverage 57.6276% 57.6393% +0.0117% ================================================ Files 849 849 Lines 126160 126162 +2 ================================================ + Hits 72703 72719 +16 + Misses 48055 48043 -12 + Partials 5402 5400 -2 ```
hongyunyan commented 6 days ago

/test dm-integration-test

ti-chi-bot commented 6 days ago

In response to a cherrypick label: new pull request created to branch release-8.2: #11362.