pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
417 stars 272 forks source link

util(dm): update checking for fake rotate event #11360

Open lance6716 opened 6 days ago

lance6716 commented 6 days ago

What problem does this PR solve?

Issue Number: close #11381

What is changed and how it works?

make fake rotate event checking more strict

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.
lance6716 commented 6 days ago

/cc @GMHDBJD

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.6148%. Comparing base (467a152) to head (cdd034a). Report is 4 commits behind head on master.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.4142% <ø> (∅)` | | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `51.1910% <0.0000%> (∅)` | | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `63.3879% <ø> (+0.0211%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `57.6148% <0.0000%> (-5.7520%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11360 +/- ## ================================================ - Coverage 63.3667% 57.6148% -5.7520% ================================================ Files 163 849 +686 Lines 14162 126162 +112000 ================================================ + Hits 8974 72688 +63714 - Misses 4621 48068 +43447 - Partials 567 5406 +4839 ```
lance6716 commented 1 day ago

/check-issue-triage-complete

ti-chi-bot[bot] commented 4 hours ago

[LGTM Timeline notifier]

Timeline:

lance6716 commented 4 hours ago

/check-issue-triage-complete

ti-chi-bot[bot] commented 2 hours ago

@lyzx2001: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiflow/pull/11360#pullrequestreview-2155908374): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lyzx2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[dm/OWNERS](https://github.com/pingcap/tiflow/blob/master/dm/OWNERS)~~ [GMHDBJD] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment