pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
425 stars 283 forks source link

DM precheck failed to check GTID when stop and then start from checkpoint with same task config #11648

Open D3Hunter opened 2 days ago

D3Hunter commented 2 days ago

What did you do?

below is the steps I summarized from a user feedback, I hasn't reproduce it locally, but from the code seems it will fail

in precheck, we are always uses the position in task config, but since we are recover from checkpoint, we should uses the position in checkpoint instead as that's checkpoint position is the real position we will use, and might also need to consider this issue https://github.com/pingcap/dm/issues/1418 https://github.com/pingcap/tiflow/blob/9062d7c0cac6839d157379c38785f55fe2c3275a/dm/pkg/checker/binlog.go#L356-L368

What did you expect to see?

No response

What did you see instead?

No response

Versions of the cluster

dm version 7.5.3, upstream unknown right now,

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
fishiu commented 1 day ago

/assign