pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
430 stars 286 forks source link

dm: handle the query in metadata from binlog #11743

Closed joccau closed 5 days ago

joccau commented 1 week ago

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/11735

What is changed and how it works?

Handle the new format of binlog metadata from mariadb to read the binlog position.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Not.

Do you need to update user documentation, design documentation or monitoring documentation?

Not.

Release note

None
sre-bot commented 1 week ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.2136%. Comparing base (b2a4f9a) to head (1020abf). Report is 7 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `59.6170% <ø> (+0.0414%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.1154% <100.0000%> (+0.0788%)` | :arrow_up: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.2957% <ø> (+0.0564%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11743/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `55.2136% <100.0000%> (+0.0626%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11743 +/- ## ================================================ + Coverage 55.1510% 55.2136% +0.0626% ================================================ Files 1002 1002 Lines 137399 137580 +181 ================================================ + Hits 75777 75963 +186 - Misses 56074 56081 +7 + Partials 5548 5536 -12 ```

🚨 Try these New Features:

ti-chi-bot[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[dm/OWNERS](https://github.com/pingcap/tiflow/blob/master/dm/OWNERS)~~ [GMHDBJD,lance6716] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 5 days ago

[LGTM Timeline notifier]

Timeline:

lance6716 commented 5 days ago

@joccau please sign CLA

joccau commented 5 days ago

@joccau please sign CLA

Done

lance6716 commented 5 days ago

/retest

lance6716 commented 5 days ago

/retest