pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
430 stars 286 forks source link

ticdc(redo, sink): return correct error in redo writer & fix default retryer (#11747) #11764

Closed ti-chi-bot closed 4 days ago

ti-chi-bot commented 6 days ago

This is an automated cherry-pick of #11747

What problem does this PR solve?

Issue Number: close #11744

What is changed and how it works?

This issue is introduced in #11011. If redo encoding worker closed since context canceld(ref the fix), the external module is not aware of the internal error anyway. Then the checkpoinTs/resolvedTs may continue to advance normally even if the redo writer has been closed.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix a bug where the redo module could not report errors correctly`.
ti-chi-bot[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/release-8.1/OWNERS)~~ [CharlesCheung96] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CharlesCheung96 commented 4 days ago

/retest

CharlesCheung96 commented 4 days ago

/retest

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@0c49d2a). Learn more about missing BASE report.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.7742% <0.0000%> (?)` | | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `51.0237% <0.0000%> (?)` | | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `63.4232% <0.0000%> (?)` | | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `57.3915% <17.6470%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## release-8.1 #11764 +/- ## ================================================ Coverage ? 57.3915% ================================================ Files ? 854 Lines ? 126069 Branches ? 0 ================================================ Hits ? 72353 Misses ? 48311 Partials ? 5405 ```