pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
430 stars 286 forks source link

fix resign owner api not processed by owner node bug #11770

Closed sdojjy closed 3 days ago

sdojjy commented 4 days ago

What problem does this PR solve?

Issue Number: close #11769

What is changed and how it works?

/api/v2/owner/resign forward to owner node

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.
ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

sdojjy commented 4 days ago

/retest

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.1685%. Comparing base (6c8dfe8) to head (c9541c7). Report is 64 commits behind head on master.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `59.5874% <100.0000%> (-1.6326%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.0692% <ø> (-0.9804%)` | :arrow_down: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.2336% <ø> (-10.1685%)` | :arrow_down: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `55.1685% <100.0000%> (-2.3062%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11770 +/- ## ================================================ - Coverage 57.4746% 55.1685% -2.3062% ================================================ Files 850 1002 +152 Lines 126407 137399 +10992 ================================================ + Hits 72652 75801 +3149 - Misses 48347 56051 +7704 - Partials 5408 5547 +139 ```

🚨 Try these New Features:

sdojjy commented 3 days ago

/retest-required

ti-chi-bot[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflow/blob/master/OWNERS)~~ [3AceShowHand,asddongmen] - ~~[cdc/api/v2/OWNERS](https://github.com/pingcap/tiflow/blob/master/cdc/api/v2/OWNERS)~~ [yudongusa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sdojjy commented 3 days ago

/retest-required

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-7.1: #11778.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-7.5: #11779.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-8.5: #11780.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-8.1: #11781.

ti-chi-bot commented 2 days ago

In response to a cherrypick label: new pull request created to branch release-6.5: #11782.