pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
430 stars 286 forks source link

puller: fix a bug that may cause error when replicate truncate table ddl #11772

Open asddongmen opened 1 week ago

asddongmen commented 1 week ago

What problem does this PR solve?

Issue Number: close #11765

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from asddongmen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiflow/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
asddongmen commented 1 week ago

/test all

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.1708%. Comparing base (6fc5a49) to head (ecd1a3a). Report is 47 commits behind head on master.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `59.5992% <100.0000%> (-1.6109%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.0654% <ø> (-0.9801%)` | :arrow_down: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.2167% <ø> (-10.1572%)` | :arrow_down: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `55.1708% <100.0000%> (-2.2954%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11772 +/- ## ================================================ - Coverage 57.4662% 55.1708% -2.2954% ================================================ Files 851 1002 +151 Lines 126462 137404 +10942 ================================================ + Hits 72673 75807 +3134 - Misses 48389 56056 +7667 - Partials 5400 5541 +141 ```

🚨 Try these New Features:

asddongmen commented 1 day ago

/test all

ti-chi-bot[bot] commented 1 day ago

@asddongmen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test 1219b30eb4332226bc62cdea4bbf8e772e47efaa link true /test cdc-integration-kafka-test
pull-cdc-integration-storage-test 1219b30eb4332226bc62cdea4bbf8e772e47efaa link true /test cdc-integration-storage-test
pull-cdc-integration-mysql-test 1219b30eb4332226bc62cdea4bbf8e772e47efaa link true /test cdc-integration-mysql-test
jenkins-ticdc/verify 1219b30eb4332226bc62cdea4bbf8e772e47efaa link true /test verify
pull-cdc-integration-pulsar-test 1219b30eb4332226bc62cdea4bbf8e772e47efaa link true /test cdc-integration-pulsar-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).