pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
430 stars 286 forks source link

Redact query arguments in dm log #11783

Closed db-will closed 1 day ago

db-will commented 2 days ago

What problem does this PR solve?

Issue Number: close #11489

What is changed and how it works?

Redact query arguments in dm log when there is retryable error happen in dm syncer.

Have searched for arguments in dm source code to find if there are any missing part for redacting, this one seems like the last missing piece.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

None

ti-chi-bot[bot] commented 2 days ago

Hi @db-will. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lance6716 commented 1 day ago

/ok-to-test

ti-chi-bot[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[dm/OWNERS](https://github.com/pingcap/tiflow/blob/master/dm/OWNERS)~~ [GMHDBJD,lance6716] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 day ago

[LGTM Timeline notifier]

Timeline:

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.1466%. Comparing base (f1f286a) to head (f26e2c0). Report is 1 commits behind head on master.

Additional details and impacted files | [Components](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cdc](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `59.5785% <ø> (∅)` | | | [dm](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.0269% <0.0000%> (-0.0097%)` | :arrow_down: | | [engine](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.2223% <ø> (-0.0283%)` | :arrow_down: | | [Flag](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tiflow/pull/11783/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `55.1466% <0.0000%> (+4.2927%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. ```diff @@ Coverage Diff @@ ## master #11783 +/- ## ================================================ + Coverage 50.8539% 55.1466% +4.2927% ================================================ Files 484 1002 +518 Lines 69680 137399 +67719 ================================================ + Hits 35435 75771 +40336 - Misses 31492 56083 +24591 - Partials 2753 5545 +2792 ```

🚨 Try these New Features: