pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
417 stars 274 forks source link

Server log file default value not work. #4880

Open mikechengwei opened 2 years ago

mikechengwei commented 2 years ago

What did you do?

Test default server log file. Ref https://docs.pingcap.com/zh/tidb/stable/deploy-ticdc.

 log-file:TiCDC 进程运行日志的地址,默认为 cdc.log。

What did you expect to see?

output log to cdc.log.

What did you see instead?

None

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

v5.4.0
overvenus commented 2 years ago

What's your command line and configuration file to start TiCDC?

mikechengwei commented 2 years ago

For example , i am not specify log-file argument :

/cdc server --addr=0.0.0.0:8301 --advertise-addr=basic-ticdc-2.basic-ticdc-peer.default.svc:8301 --gc-ttl=86400
mikechengwei commented 2 years ago

BTW, i use tidb operator deploy ticdc , operator can't set the log-file empty,because ticdc not set the default value .Ref: https://github.com/pingcap/tidb-operator/pull/4473

overvenus commented 2 years ago

BTW, i use tidb operator deploy ticdc , operator can't set the log-file empty,because ticdc not set the default value .Ref: pingcap/tidb-operator#4473

Without --log-file, TiCDC should output logs to the std out. I think the documentation needs update.

mikechengwei commented 2 years ago

BTW, i use tidb operator deploy ticdc , operator can't set the log-file empty,because ticdc not set the default value .Ref: pingcap/tidb-operator#4473

Without --log-file, TiCDC should output logs to the std out. I think the documentation needs update.

If user not specify log-file using tool ,the log will output to cdc.log. I think ticdc should help tiup and tidb operator unify logfile default value. Instead, tiup and operator each have a log file default value standards, which affects the user experience. @overvenus