pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
428 stars 286 forks source link

Why metric of conflictDetectDurationHis has not been merged into tiflow master branch,but included in v6.0.0 #5182

Closed AricSu closed 2 years ago

AricSu commented 2 years ago

Before asking a question, make sure you have

What is your question?

There is nothing in master branch,as below searching image.

Searching in v6.0.0 branch of tiflow : image

overvenus commented 2 years ago

I thik both release-6.0 and master include the metric. Try "conflictDetectDurationHis"?

➜ gco release-6.0
Switched to branch 'release-6.0'
Your branch is behind 'origin/release-6.0' by 8 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

➜ grep -Rn conflictDetectDurationHis cdc
cdc/sink/metrics.go:52: conflictDetectDurationHis = prometheus.NewHistogramVec(
cdc/sink/metrics.go:113:        registry.MustRegister(conflictDetectDurationHis)
cdc/sink/mysql.go:173:  metricConflictDetectDurationHis := conflictDetectDurationHis.

➜ gco master 
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

➜ grep -Rn conflictDetectDurationHis cdc
cdc/sink/metrics.go:52: conflictDetectDurationHis = prometheus.NewHistogramVec(
cdc/sink/metrics.go:105:        registry.MustRegister(conflictDetectDurationHis)
cdc/sink/mysql.go:185:  metricConflictDetectDurationHis := conflictDetectDurationHis.
3AceShowHand commented 2 years ago

closed