pingcap / tiflow

This repo maintains DM (a data migration platform) and TiCDC (change data capture for TiDB)
Apache License 2.0
426 stars 282 forks source link

CLI can not show the warnings when creating the changefeed #8161

Open Rustin170506 opened 1 year ago

Rustin170506 commented 1 year ago

What did you do?

Create a changefeed with some problematic configurations.

For example: Imagine we have a Kafka server and it does not have the min.insync.replicate configuration.

  1. create a changefeed with command ./cdc cli changefeed create --sink-uri="kafka://127.0.0.1:9092/test?max-message-bytes=1048576&protocol=open-protocol&replication-factor=1"

What did you expect to see?

Show the warnings for these problematic configurations.

We should show:

[2023/02/02 14:50:34.520 +08:00] [WARN] [kafka.go:460] ["TiCDC cannot find `min.insync.replicas` from broker's configuration, please make sure that the replication factor is greater than or equal to the minimum number of in-sync replicasif you want to use `required-acks` = -1.Otherwise, TiCDC will not be able to send messages to the topic."]

What did you see instead?

Nothing. I can find the warnings in server's log instead of cli's log.

Versions of the cluster

master

nongfushanquan commented 1 year ago

/assign @hi-rustin

asddongmen commented 4 months ago

It should be a enhancement instead of a bug.