pingcap / tispark

TiSpark is built for running Apache Spark on top of TiDB/TiKV
Apache License 2.0
883 stars 244 forks source link

Probe tiflash #2640

Closed shiyuhang0 closed 1 year ago

shiyuhang0 commented 1 year ago

What problem does this PR solve?

https://github.com/pingcap/tispark/pull/2619

What is changed and how it works?

Check List

Manual test (add detailed scripts or steps below)

start 2 tiflash

tiup playground v6.5.0 --tiflash 2

create a table named test.t

set 2 tiflash replicas for test.t

ALTER TABLE t SET TIFLASH REPLICA 2;

suspend tiflash

kill -stop 4594
kill -stop 4595

read from tiflash

spark.conf
            .set(TiConfigConst.ISOLATION_READ_ENGINES, TiConfigConst.TIFLASH_STORAGE_ENGINE)
spark.sql("select * from tidb_catalog.test.t").show()

TiSpark will retry with the following log

image

recovery tiflash, tispark success

kill -cont 4594
ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
shiyuhang0 commented 1 year ago

/run-all-tests

shiyuhang0 commented 1 year ago

/run-all-tests

shiyuhang0 commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: b8704707b1a95cc54ffff4de57b5131813dd8a38

ti-chi-bot commented 1 year ago

In response to a cherrypick label: new pull request created to branch release-3.2: #2648.