pingcap / tispark

TiSpark is built for running Apache Spark on top of TiDB/TiKV
Apache License 2.0
880 stars 244 forks source link

fix mutil_uniq (#2650) #2665

Closed ti-chi-bot closed 1 year ago

ti-chi-bot commented 1 year ago

This is an automated cherry-pick of #2650

What problem does this PR solve?

close #2649

What is changed and how it works?

The behavior of other version/client

  1. TiSpark 3.0 does not pass unique in indexscan executor
  2. TIDB needs some checks before passing unique https://github.com/pingcap/tidb/blob/4ae5be190b0017675deedd9af8b80d8868e03f0e/planner/core/plan_to_pb.go#L271

TiSpark lacks the necessary information to judge if it can pass unique. So we just delete it. Lack unique in indexscan only slows the performance but does not influence the correct. See the pr's comment for more details https://github.com/pingcap/tidb/issues/29650

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
shiyuhang0 commented 1 year ago

/run-all-tests

shiyuhang0 commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: 5a59e666b75a8dd49a755da88ca803afd1251c71