search

pingcap / tispark

TiSpark is built for running Apache Spark on top of TiDB/TiKV
Apache License 2.0
880 stars 244 forks source link

The reasion why If enableAuth get PDAddress from TiDB else from spark conf ? #2728

Closed wfxxh closed 11 months ago

wfxxh commented 1 year ago

First: As the title. Second: I think we can change the method getTiDBSnapshot(sparksession) in TiUtil to lazy val. Third: The 'override def initialize in TiCatalog' , I think we can just change the sparkConfToTiConfWithoutPD to sparkConfToTiConf so that we would not gave the 'pd.addresses' twice (spark.tispark.pd.addresses and spark.sql.catalog.tidb_catalog.pd.addresses)

github-actions[bot] commented 11 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 11 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.