Closed shiyuhang0 closed 2 months ago
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xuanyu66, zhangyangyu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-07-23 11:56:33.072751912 +0000 UTC m=+959815.063693367
: :ballot_box_with_check: agreed by xuanyu66.2024-07-25 03:34:16.270161046 +0000 UTC m=+1102478.261102516
: :ballot_box_with_check: agreed by zhangyangyu.In response to a cherrypick label: new pull request created to branch release-3.1
: #2786.
In response to a cherrypick label: new pull request created to branch release-3.2
: #2787.
What problem does this PR solve?
close #2750
fix column mismatch reported by tikv. https://github.com/tikv/tikv/blob/254ceaaa654a70d78919ee5d85f5b4cbe3c444a3/components/tidb_query_executors/src/index_scan_executor.rs#L113
This occurs when the
primary_column_ids
number is more than columns number in the index scan of DAGRequest. Example:What is changed and how it works?
Add primary columns to columns in index scan of DAGRequest when pk is command handle.
Add this because TiDB also do like this. Ref: https://github.com/pingcap/tidb/blob/ddcaadbb856f0890e91e4c77991f0d2aa5aa93d0/pkg/planner/core/planbuilder.go#L1515
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository