search

pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

tiup and lightning not working well together. #1488

Closed dveeden closed 2 years ago

dveeden commented 2 years ago
  1. What did you do?

Use tiup tidb-lightning -backend=tidb -tidb-host=...

  1. What did you expect to see?

Use the specified host

  1. What did you see instead?

Usage info

  1. What version of BR and TiDB/TiKV/PD are you using?
Release Version: v5.1.0
Git Commit Hash: f2fcbfa5a9783e33ff44b696920d8bbe6a19eaa6
Git Branch: heads/refs/tags/v5.1.0
Go Version: go1.16.4
UTC Build Time: 2021-06-24 07:09:26
Race Enabled: false

tiup -- tidb-lightning -backend=tidb -tidb-host=... does work.

This might be causing issue if people follow https://docs.pingcap.com/tidbcloud/public-preview/migrate-data-into-tidb#step-2-import-data-to-your-tidb-cluster and use tiup instead of manually downloading and updating binaries.

This is a copy of https://github.com/pingcap/br/issues/1350 as I can't move issue between repos.

AstroProfundis commented 2 years ago

I don't quite get the problem, do you mean the -tidb-host argument is not correctly passed to lightning?

dveeden commented 2 years ago

yes indeed

On Thu, Jul 15, 2021, 11:22 Allen Zhong @.***> wrote:

I don't quite get the problem, do you mean the -tidb-host argument is not correctly passed to lightning?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pingcap/tiup/issues/1488#issuecomment-880539513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWZFGSDEJPIQYVM57MGS3TX2SENANCNFSM5ANCFEBA .

AstroProfundis commented 2 years ago

I think it's an issue with cobra not handling solo dash style long arguments the same way as flag. We may need to find a way to deal that.

AstroProfundis commented 2 years ago

dupe w/ #862

dveeden commented 2 years ago

dupe w/ #862

Yes indeed, let's close this one as duplicate.