cluster: not abort destroy if cannot delete files

nexustar commented 1 year ago

What problem does this PR solve?

close #2233

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 71.43% and project coverage change: +30.61% :tada:

Comparison is base (0a60bc3) 25.47% compared to head (7ac4a30) 56.07%.

:exclamation: Current head 7ac4a30 differs from pull request most recent head 60a4c34. Consider uploading reports for the commit 60a4c34 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2256 +/- ## =========================================== + Coverage 25.47% 56.07% +30.61% =========================================== Files 290 320 +30 Lines 30528 33873 +3345 =========================================== + Hits 7775 18994 +11219 + Misses 21881 12611 -9270 - Partials 872 2268 +1396 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.94% <71.43%> (?)` | | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.73% <71.43%> (?)` | | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.74% <ø> (?)` | | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.87% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/pingcap/tiup/pull/2256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [pkg/cluster/operation/destroy.go](https://app.codecov.io/gh/pingcap/tiup/pull/2256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvb3BlcmF0aW9uL2Rlc3Ryb3kuZ28=) | `60.89% <71.43%> (ø)` | | ... and [231 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2256/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

2023-08-18 13:56:43.050859718 +0000 UTC m=+898567.599875702: :ballot_box_with_check: agreed by kaaaaaaang.

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup