fix pd microservice component id

iosmanthus commented 1 year ago

What problem does this PR solve?

close #2270

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 1 year ago

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2272#pullrequestreview-1610621949): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -3.07% :warning:

Comparison is base (b1557f8) 43.44% compared to head (1447347) 40.36%.

:exclamation: Current head 1447347 differs from pull request most recent head b5f5481. Consider uploading reports for the commit b5f5481 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2272 +/- ## ========================================== - Coverage 43.44% 40.36% -3.07% ========================================== Files 305 266 -39 Lines 33169 28795 -4374 ========================================== - Hits 14408 11623 -2785 + Misses 17023 15559 -1464 + Partials 1738 1613 -125 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2272/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.88% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. [see 93 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2272/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 1 year ago

@JmPotato: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2272#pullrequestreview-1610633354): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 1 year ago

/lgtm

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

2023-09-06 06:08:52.37999865 +0000 UTC m=+2512096.929014622: :ballot_box_with_check: agreed by kaaaaaaang.

iosmanthus commented 1 year ago

/merge

kaaaaaaang commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup