pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
427 stars 313 forks source link

Support scheduling service #2273

Closed rleungx closed 1 year ago

rleungx commented 1 year ago

What problem does this PR solve?

Support scheduling service for tiup playground

What is changed and how it works?

Check List

Tests

Release notes:

NONE
codecov-commenter commented 1 year ago

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (b8fbc84) 55.53% compared to head (cb876b0) 55.44%.

:exclamation: Current head cb876b0 differs from pull request most recent head 35e26e8. Consider uploading reports for the commit 35e26e8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2273 +/- ## ========================================== - Coverage 55.53% 55.44% -0.08% ========================================== Files 326 326 Lines 34413 34473 +60 ========================================== + Hits 19108 19113 +5 - Misses 13024 13072 +48 - Partials 2281 2288 +7 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2273/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2273/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.45% <5.00%> (-0.04%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2273/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.68% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2273/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.43% <0.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [components/playground/instance/instance.go](https://app.codecov.io/gh/pingcap/tiup/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL2luc3RhbmNlL2luc3RhbmNlLmdv) | `44.29% <0.00%> (ø)` | | | [components/playground/main.go](https://app.codecov.io/gh/pingcap/tiup/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL21haW4uZ28=) | `59.24% <50.00%> (+0.78%)` | :arrow_up: | | [components/playground/instance/pd.go](https://app.codecov.io/gh/pingcap/tiup/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL2luc3RhbmNlL3BkLmdv) | `48.72% <0.00%> (-6.09%)` | :arrow_down: | | [components/playground/playground.go](https://app.codecov.io/gh/pingcap/tiup/pull/2273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL3BsYXlncm91bmQuZ28=) | `44.10% <1.79%> (-1.91%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rleungx commented 1 year ago

/cc @lhy1024 @JmPotato

ti-chi-bot[bot] commented 1 year ago

@rleungx: GitHub didn't allow me to request PR reviews from the following users: lhy1024, JmPotato.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/tiup/pull/2273#issuecomment-1722926626): >/cc @lhy1024 @JmPotato Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 1 year ago

/lgtm

kaaaaaaang commented 1 year ago

/approve

kaaaaaaang commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 year ago

@rleungx: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 1 year ago

/lgtm

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline: