pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
427 stars 313 forks source link

cluster/dm: support ignore version check when upgrade #2282

Closed nexustar closed 1 year ago

nexustar commented 1 year ago

What problem does this PR solve?

What is changed and how it works?

image

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 63.64% and project coverage change: -0.05% :warning:

Comparison is base (9d1ba4b) 55.80% compared to head (38a15fe) 55.75%.

:exclamation: Current head 38a15fe differs from pull request most recent head 13852d8. Consider uploading reports for the commit 13852d8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2282 +/- ## ========================================== - Coverage 55.80% 55.75% -0.05% ========================================== Files 323 323 Lines 34095 34100 +5 ========================================== - Hits 19026 19012 -14 - Misses 12795 12814 +19 Partials 2274 2274 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.77% <50.00%> (-0.05%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.71% <50.00%> (+<0.01%)` | :arrow_up: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.68% <ø> (-0.02%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.88% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.61% <36.36%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/pingcap/tiup/pull/2282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [pkg/cluster/manager/upgrade.go](https://app.codecov.io/gh/pingcap/tiup/pull/2282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvbWFuYWdlci91cGdyYWRlLmdv) | `56.72% <20.00%> (-0.57%)` | :arrow_down: | | [components/cluster/command/upgrade.go](https://app.codecov.io/gh/pingcap/tiup/pull/2282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9jbHVzdGVyL2NvbW1hbmQvdXBncmFkZS5nbw==) | `66.67% <100.00%> (+1.96%)` | :arrow_up: | | [components/dm/command/upgrade.go](https://app.codecov.io/gh/pingcap/tiup/pull/2282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9kbS9jb21tYW5kL3VwZ3JhZGUuZ28=) | `57.14% <100.00%> (+2.14%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2282/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 1 year ago

/lgtm

kaaaaaaang commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 year ago

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 1 year ago

/lgtm

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline: