update tidbver.TiDBSupportUpgradeAPI

kaaaaaaang commented 9 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4f5d9e3) 55.87% compared to head (96924dc) 55.85%.

:exclamation: Current head 96924dc differs from pull request most recent head 8626df3. Consider uploading reports for the commit 8626df3 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2289 +/- ## ========================================== - Coverage 55.87% 55.85% -0.02% ========================================== Files 324 324 Lines 34164 34164 ========================================== - Hits 19087 19079 -8 - Misses 12799 12808 +9 + Partials 2278 2277 -1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.89% <0.00%> (-0.02%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.57% <0.00%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [pkg/cluster/operation/upgrade.go](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvb3BlcmF0aW9uL3VwZ3JhZGUuZ28=) | `47.60% <ø> (+0.41%)` | :arrow_up: | | [pkg/cluster/manager/patch.go](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvbWFuYWdlci9wYXRjaC5nbw==) | `41.61% <0.00%> (-0.62%)` | :arrow_down: | | [pkg/cluster/manager/reload.go](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvbWFuYWdlci9yZWxvYWQuZ28=) | `66.00% <0.00%> (-1.00%)` | :arrow_down: | | [pkg/cluster/manager/upgrade.go](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvbWFuYWdlci91cGdyYWRlLmdv) | `56.22% <0.00%> (-0.50%)` | :arrow_down: | | [pkg/tidbver/tidbver.go](https://app.codecov.io/gh/pingcap/tiup/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL3RpZGJ2ZXIvdGlkYnZlci5nbw==) | `86.15% <0.00%> (-4.32%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 9 months ago

@zimulala: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2289#pullrequestreview-1681650600): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 9 months ago

/approve

ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kaaaaaaang commented 9 months ago

/lgtm

ti-chi-bot[bot] commented 9 months ago

@kaaaaaaang: you cannot LGTM your own PR.

In response to [this](https://github.com/pingcap/tiup/pull/2289#issuecomment-1766051257): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

pingcap / tiup