add a new flag '--numa' to show numa in display command

KanShiori commented 11 months ago

What problem does this PR solve?

Close #2294

What is changed and how it works?

add a new flag '--numa' to show numa in display command.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Deploy a new cluster.
Display with '--numa' flag.
- No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

add a new flag '--numa' to show numa in display command

codecov-commenter commented 11 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (79d3011) 55.55% compared to head (cbb9a94) 50.20%.

:exclamation: Current head cbb9a94 differs from pull request most recent head 72337a9. Consider uploading reports for the commit 72337a9 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2295 +/- ## ========================================== - Coverage 55.55% 50.20% -5.35% ========================================== Files 326 325 -1 Lines 34378 34410 +32 ========================================== - Hits 19098 17274 -1824 - Misses 12998 14869 +1871 + Partials 2282 2267 -15 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.50% <76.74%> (-0.13%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.46% <28.57%> (-0.04%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.48% <0.00%> (-0.04%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.70% <0.00%> (-0.01%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2295/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [components/cluster/command/display.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9jbHVzdGVyL2NvbW1hbmQvZGlzcGxheS5nbw==) | `45.83% <100.00%> (+0.76%)` | :arrow_up: | | [pkg/cluster/spec/alertmanager.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9hbGVydG1hbmFnZXIuZ28=) | `68.10% <100.00%> (+0.56%)` | :arrow_up: | | [pkg/cluster/spec/cdc.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9jZGMuZ28=) | `58.42% <100.00%> (-0.08%)` | :arrow_down: | | [pkg/cluster/spec/drainer.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9kcmFpbmVyLmdv) | `57.07% <100.00%> (+0.47%)` | :arrow_up: | | [pkg/cluster/spec/grafana.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9ncmFmYW5hLmdv) | `61.33% <100.00%> (-2.34%)` | :arrow_down: | | [pkg/cluster/spec/instance.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9pbnN0YW5jZS5nbw==) | `65.60% <100.00%> (+0.56%)` | :arrow_up: | | [pkg/cluster/spec/monitoring.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9tb25pdG9yaW5nLmdv) | `72.21% <100.00%> (-2.86%)` | :arrow_down: | | [pkg/cluster/spec/pd.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9wZC5nbw==) | `67.02% <100.00%> (+0.23%)` | :arrow_up: | | [pkg/cluster/spec/pump.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9wdW1wLmdv) | `63.19% <100.00%> (-3.48%)` | :arrow_down: | | [pkg/cluster/spec/tidb.go](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy90aWRiLmdv) | `66.07% <100.00%> (+0.41%)` | :arrow_up: | | ... and [7 more](https://app.codecov.io/gh/pingcap/tiup/pull/2295?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | | ... and [55 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 11 months ago

/lgtm

ti-chi-bot[bot] commented 11 months ago

[LGTM Timeline notifier]

Timeline:

2023-10-31 06:16:52.278739601 +0000 UTC m=+2933809.865849731: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 11 months ago

/approve

ti-chi-bot[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup