Closed KanShiori closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
bdf6f26
) 55.54% compared to head (2aa3450
) 55.53%.:exclamation: Current head 2aa3450 differs from pull request most recent head a43b536. Consider uploading reports for the commit a43b536 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kaaaaaaang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2023-10-31 06:15:35.33369352 +0000 UTC m=+2933732.920803668
: :ballot_box_with_check: agreed by kaaaaaaang.2023-10-31 06:17:26.298401217 +0000 UTC m=+2933843.885511344
: :heavy_multiplication_x::repeat: reset by KanShiori.New changes are detected. LGTM label has been removed.
What problem does this PR solve?
Close #2221
What is changed and how it works?
Use port not root user to probe db in playground.
Check List
Tests
Create a tidb configuration that contains init SQL to init root password.
Execute![image](https://github.com/pingcap/tiup/assets/26425336/4c183c74-29ba-46da-93a2-a4cadb36e900)
tiup playground --db.config tidb.toml
.Connect db with password successfully.![image](https://github.com/pingcap/tiup/assets/26425336/f8788ebc-7d2d-4cb2-b7cf-b398c24ed2f5)
Code changes
Side effects
Related changes
Release notes: