playground: fix tiproxy metrics addr

xhebox commented 1 year ago

What problem does this PR solve?

Playground promtheus pulls wrong metric addresses for tiproxy.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

Fix tiproxy metrics on playground

codecov-commenter commented 1 year ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (721b065) 55.47% compared to head (7448ca0) 55.43%.

:exclamation: Current head 7448ca0 differs from pull request most recent head 76a461b. Consider uploading reports for the commit 76a461b to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2299 +/- ## ========================================== - Coverage 55.47% 55.43% -0.04% ========================================== Files 326 326 Lines 34479 34478 -1 ========================================== - Hits 19125 19111 -14 - Misses 13063 13075 +12 - Partials 2291 2292 +1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2299/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.36% <61.90%> (-0.07%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.67% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.43% <0.00%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [components/playground/instance/instance.go](https://app.codecov.io/gh/pingcap/tiup/pull/2299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL2luc3RhbmNlL2luc3RhbmNlLmdv) | `44.29% <100.00%> (ø)` | | | [components/playground/playground.go](https://app.codecov.io/gh/pingcap/tiup/pull/2299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL3BsYXlncm91bmQuZ28=) | `44.00% <100.00%> (-0.10%)` | :arrow_down: | | [components/playground/monitor.go](https://app.codecov.io/gh/pingcap/tiup/pull/2299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL21vbml0b3IuZ28=) | `76.67% <81.82%> (-4.39%)` | :arrow_down: | | [components/playground/instance/tiproxy.go](https://app.codecov.io/gh/pingcap/tiup/pull/2299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL2luc3RhbmNlL3RpcHJveHkuZ28=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

2023-11-03 07:01:27.271763579 +0000 UTC m=+3195684.858873724: :ballot_box_with_check: agreed by kaaaaaaang.

xhebox commented 1 year ago

/approve

kaaaaaaang commented 1 year ago

/lgtm

kaaaaaaang commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup